Hi !
This one will be relatively short, remember how I wrote a new operation to update proposals and updated the way proposal fees were calculated ? Well I didn't write unit tests (although I tested them extensively) at the time.
This is now done:
https://gitlab.syncad.com/hive/hive/-/merge_requests/52
this was part of this issue: https://gitlab.syncad.com/hive/hive/-/issues/51
The idea behind unit tests is mostly to prevent regressions, regressions happens when a new features somehow affect another feature. By running unit tests we can tell if things are behaving correctly (this is not a silver bullet though, it's one of the many ways of testing software).
If you want to learn more about unit tests: http://softwaretestingfundamentals.com/unit-testing/
And while doing those tests I noticed a "bug" in the original proposal implementation and filed an issue, I will tackle it later on: https://gitlab.syncad.com/hive/hive/-/issues/53
It's not really a bug, it's more of an edge case and it doesn't really have any serious consequences. But it should be handled before someone actually runs into that edge case
