STEEM Community QA 27-10-2018

Issue / Feature / Commit to be TESTED:

Report from @ura-soul in #witness-support

ura.soul 8:50 PM
three odd things i notice here:

there is a warning about the /shm/ path for shared mem (as far as i know i have always used that path).
changing the path to /dev/shm/ doesn't stop the warning
i see an error relating to a standard config param:

terminate called after throwing an instance of 'boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::program_options::invalid_bool_value> >'
what(): the argument ('33') for option 'required-participation' is invalid. Valid choices are 'on|off', 'yes|no', '1|0' and 'true|false'

the blockchain version shown is 0.19.6 - even though i completely deleted the steem-docker folder and started fresh
seems like there is a cached version of the build on the system
i don't have any notes here on how to clean that out

bobinson 9:09 PM
required-participation ----> this is a value in the config file. What does it say ?
it has to be either true or false and its currently 33 ?
timcliff 9:13 PM
required participation is how many witnesses need to be in a round for it to be considered valid. at one extreme 0% required participation would mean that one witness could keep producing all the blocks, and your node would consider it a valid chain. at the other extreme, if you had 100% required participation, then if a witness missed a block during the round, then your node would consider it an invalid fork
true/false should not be considered valid values. it should be 0-100
correction: it looks like 99 is the highest it is allowed to go

bobinson 9:24 PM
hmm - not sure. I looked at the boost error message above "Valid choices are 'on|off', 'yes|no', '1|0' and 'true|false'"

ura.soul 11:39 PM
Has anyone else seen these errors in this or recent builds?
I haven't seen anyone reporting these so far..
--

Summary

required-participation configuration option in the config file must be tested. There is a related issue/commits here: https://github.com/steemit/steem/issues/3025

How to test ?

As per the documentation the acceptable values are 0 to 99 and are integers.

The sample configuration file on the other hand shows the following

# Percent of witnesses (0-99) that must be participating in order to produce blocks

false is a bool while the documentation mentions this as an integer.

Scenario1: Compile STEEM blockchain and start the chain with required-participation with the default value.
Scenario2: Try True/False and report the result.
Scenario3: use zero (0) and report the result.
Scenario4: use one (1) and report the result.

Scenario3 and Scenario4 are going to be interesting as it will be considered as True/False and also between 0-99

Scenario5: comment the field and report the result.

Build Environment

Config options:

[root@STEEM-QA /mnt/steem/build]$ cmake --DCMAKE_BUILD_TYPE=Debug ..
[root@STEEM-QA /mnt/steem/build]$ rm -f CMakeCache.txt
[root@STEEM-QA /mnt/steem/build]$make -j66
[root@STEEM-QA /mnt/steem/build]$ make -j66 install
[root@STEEM-QA /mnt/steem/build]$ steemd -d /mnt/steem/build/

This auto generated the config file.

Results:

This section will report the results and if possible expected results

*Scenario1: The chain starts without any issues.

Scenario2: Tried with false and the result is below:

[root@STEEM-QA /mnt/steem/build]$ steemd -d /mnt/steem/build/ Error parsing command line: the argument ('false') for option 'required-participation' is invalid

true, on, off all has the same result.