You did a great job with this task request. It really cool to take the time to improve an open source project and actifits is worth it in my opinion.
Let's go for the review:
Why the gitignore is so huge? It seems a little bit of an overkill
Useless comments war mouahaha, are those really necessary? You got a few of these.
but this one is good!
https://github.com/mcfarhat/actifit-bot/pull/1/files#diff-0364f57fbff2fabbe941ed20c328ef1aR38 => Why do you keep this?
You're using a lot of console.log but you've implemented a log util why not use it? Either log what's useful or remove console.log that are here for debug purposes.
You're mixin
const
var
andlet
notation. You should drop thevar
Sometimes you're using
{}
sometime not with ifs and elses which leads to things like that
if(XXX) {
} else if()
XXX
else {
XXX
XXX
}
I think it's weird to read
You've got useless padding
Using
++
is a bad practice => https://eslint.org/docs/rules/no-plusplusYou're mixin
function(){}
with() => {}
arrow notationSometimes you use
==
instead of===
You're mixing camelCase and snakeCase notation
You've left dead code :p feeling sentimental?
You've got indentation issues
From the few previous issues I think you should add prettier and/or eslint to have a homogeneous code.
Nicely done on the
getVotingPower
function implementation you didn't forgot about the last vote time!Yeah you use the Async syntaxe
steem.api.getRebloggedByAsync
! +1I see that you've got some knowledge of mongodb
await db.collection('token_transactions').aggregate
+1 too :p
In overall this is a good but you're using old javascript notations with new ones (ES6, ...) if think using eslint would really benefit you.
Keep up the work, congrats!
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
RE: Contribution - Actifits NodeJS voting bot and token calculator