RE: RE: Contribution - Actifits NodeJS voting bot and token calculator
You are viewing a single comment's thread from:

RE: Contribution - Actifits NodeJS voting bot and token calculator

RE: Contribution - Actifits NodeJS voting bot and token calculator

You did a great job with this task request. It really cool to take the time to improve an open source project and actifits is worth it in my opinion.

Let's go for the review:

  • Why the gitignore is so huge? It seems a little bit of an overkill

  • Useless comments war mouahaha, are those really necessary? You got a few of these.

but this one is good!

if(XXX) {
} else if()
XXX
else {
XXX
XXX
}

I think it's weird to read

  • You've got useless padding

  • Using ++ is a bad practice => https://eslint.org/docs/rules/no-plusplus

  • You're mixin function(){} with () => {} arrow notation

  • Sometimes you use == instead of ===

  • You're mixing camelCase and snakeCase notation

  • You've left dead code :p feeling sentimental?

  • You've got indentation issues

  • From the few previous issues I think you should add prettier and/or eslint to have a homogeneous code.

  • Nicely done on the getVotingPower function implementation you didn't forgot about the last vote time!

  • Yeah you use the Async syntaxe steem.api.getRebloggedByAsync! +1

  • I see that you've got some knowledge of mongodb await db.collection('token_transactions').aggregate +1 too :p

In overall this is a good but you're using old javascript notations with new ones (ES6, ...) if think using eslint would really benefit you.

Keep up the work, congrats!

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

H2
H3
H4
3 columns
2 columns
1 column
Join the conversation now