Spoke to both team members that told me not to refactor this... It seems they misunderstood what I was refactoring, they thought I was refactoring code that they were also refactoring and changing and that there would be a bunch of conflicts. Turns out none of them will have conflicts with this change.

They both accepted the code, and the app is now in QA being tested, hopefully QA won't send it back because some unrelated thing is wrong (which sometimes happens). Will make them reviewers in the PR to be 100% sure no issues arise.

The team wants more written communication, and this is what happens with written communication. Doing a call and sharing the screen is much easier and faster.

#engineering #software #mydiary