Minecolonies & The Progress Manager
Hey everyone, one thing we had noticed was that one of the main issues we have with our userbase is user retention. This means that we got a ton of people playing our modification but a lot of people give up early on because they don't get how it works.
To improve this we created a 3 phase work plan.
In this post, I will cover the first of the 3. I also call it:
The progress Manager basically tracks the progress of a colony and prints useful tips on the way to guide the player to develop a healthy colony.
Examples are as the above screenshot shows the placement of the colony but also placement of other buildings, spawning of colonists, the building of buildings etc.
The first thing I did was creating an Enum for all progress types.
And then following that I designed the interface of all methods I am going to need.
For that, I took the enum and tried to figure out which events they have in common to figure out which events we're going to need to support.
Following that I added the principal methods of it:
To trigger the progress type to notify the player.
To make sure the player can turn these messages on and off.
Methods to persist the data.
To check if it is turned on or off.
The progress methods in general divide then into the right subevents.
As the progress build building message which will then trigger the right enum value.
And reading and writing stores and reads it from NBT to persist it over a longer period of time.
The trigger method on the other hand checks if progress should be printed and if so it checks if it triggered it already.
If not it will print the progress and store it as triggered.
After that, I had to add the progress handler hooks into the respective classes and add a button to the town hall to turn it on and off.
For that, I also needed a message to synch this to the server.
Besides, that people were complaining about the builder not being very efficient so I gave him an overhaul.
In this sense I changed two principal parts:
#1 Improve his positioning to be more realistic
#2 Picking up all blocks he will need for the building.
For the first one, I update the walk to construction site method to be more specific for the builder. So he updates the position if he is too far or too close to the block is building at.
@Override
public boolean walkToConstructionSite(final BlockPos targetPos)
{
if (workFrom == null || MathUtils.twoDimDistance(targetPos, workFrom) < MIN_DISTANCE || MathUtils.twoDimDistance(targetPos, workFrom) > ACCEPTANCE_DISTANCE)
{
workFrom = getWorkingPosition(targetPos);
}
return worker.isWorkerAtSiteWithMove(workFrom, MAX_DISTANCE) || MathUtils.twoDimDistance(worker.getPosition(), workFrom) < ACCEPTANCE_DISTANCE;
}
And then I update the position finding the code to calculate a block in distance to the block he is trying to place on a block where he can stand.
So I get the general location of the building.
I use this to find a reasonable y level to start checking and a useable y level to stop checking.
Then I calculate the direction from which the worker will approach it.
After that, I'd do a range search around these variables.
The second was a bit more complicated.
For it, I created a new state for the builder which would be picking up.
And I created two new methods which define what he should do after certain actions.
So, after a requested pickup he would start dumping all blocks he won't need.
And after the dumping he would pick up all the blocks he is going to need.
To define the block he is going to need we query the list of required items in his building and then go into a pickup stage for each of them if we don't have a similar item in the inventory already or if our inventory is not full.
/**
* State to pick up material before going back to work.
* @return the next state to go to.
*/
public AIState pickUpMaterial()
{
final BuildingBuilder building = getOwnBuilding();
final List<Predicate<ItemStack>> neededItemsList = new ArrayList<>(building.getRequiredItemsAndAmount().keySet());
if (neededItemsList.size() <= pickUpCount || InventoryUtils.openSlotCount(new InvWrapper(worker.getInventoryCitizen())) < MIN_OPEN_SLOTS)
{
pickUpCount = 0;
return START_WORKING;
}
needsCurrently = neededItemsList.get(pickUpCount);
pickUpCount++;
return GATHERING_REQUIRED_MATERIALS;
}
In the gather stage, it would then search this item in all chests which are connected to his building and following that path to it and pick the item up.
The new walking around made him a bit less efficient though, that's why I had the idea to store his progress.
Unfortunately, until now, reloading the world would make the builder start over which is a bit stupid (also because just teleporting away would cause that as well).
So I created three new variables in the building of the builder.
a) The last progress position
b) The stage he was at
c) A counter.
So, on each progress, he would add the progress position, make sure to save this every 50 progress positions (to avoid spending too much CPU time on saving) and resetting it also when the building would be ready.
In the structure AI he would then retrieve this position and set it on structure loading:
I also made sure to reset it on structure cancellation.
And, finally, I needed to get this information from and to the structure.
So, I had to add getters and setters there as well.
Besides that, I fixed a bug where the deliveryman would try to gather from the warehouse (players didn't like that one too much).
By excluding it from the gather calc.
final List<AbstractBuilding> buildings = worker.getCitizenColonyHandler().getColony().getBuildingManager().getBuildings().values().stream()
.filter(building -> !(building instanceof BuildingWareHouse || building instanceof BuildingTownHall || building.isBeingGathered()))
.collect(Collectors.toList());
Besides that, I fixed that blocks get always registered to the required blocks list when the builder notices he needs them (Because else he would dump them right back after picking them up).
So always when he requests a block he will check if he has it in his list, and if not would request it.
I hope this will make our builder a bit more stable and as well more interesting to watch, at the same time it should help binding players to us as well.
See you the next time!
Pull Requests:
https://github.com/ldtteam/minecolonies/pull/2781
https://github.com/ldtteam/minecolonies/pull/2801
https://github.com/ldtteam/minecolonies/pull/2807
https://github.com/ldtteam/minecolonies/pull/2812