RE: RE: Updates to spltools, downloading settings and identifying the set of a card.
You are viewing a single comment's thread from:

RE: Updates to spltools, downloading settings and identifying the set of a card.

Words
143
Reading
1 min
Listen
Play
2y

Thanks! I will consider adding an Enum for the editions. I've not used Enums much in the past, since dictionaries do pretty much the same, but I see the argument for using it for readability.

I split the get_card_data and get_card_data_raw functions because I've found that I would often loop over cards in the list and get some data from each card to do other stuff. The problem was that sometimes an id would be missing in the list, and then my scripts would continue to run fine, but introduce bugs in lookups by id later on, since I typically did not track that all the way through my functions. Using a dict instead will give an error if I try to index an id that does not exist, which will remind me to be careful about data processing further down the line.

@kalkulus: Thanks! I will | Ecency