Words
130
Reading
1 min
Listen
Play
8y
Thank you for your contribution.
- The build is failing on the github page.
- It would be nice to have some unit tests to cover the new classes you added.
- The
refresh()is actually clearing the caching (doesn't do what exactly it says), it would be better to move (or re-organise) the correct logics e.g the code ingetTaskdatainto this function. - Often, the chainning such as
$this->Makerlog->getRequest()->get('/tasks/sync/');is a code smell, because something may be null in the middle, try to haveif nullcheck, then throw exception accordingly.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
RE: Tasks API implementation into the PHP Client for Makerlog