My First Open Source Contribution Ever

Words
637
Reading
3 min
Listen
Play
9y

imgwithscreenshot

You can find the link to the referenced pull request here, (if for example you are not viewing this post from Utopian).

This was a trivial fix, so according to Utopian rules, it's likely to be rejected, but it's likely people would not have been able to find it without looking specifically for it. The linked pull request has all the screenshots of the change, and I can also tell you what it looks like.

Basically, when you see your payout numeric number, and click it, a box pops up telling you "Pending Payout: $X in Y days". Except if you're in the Russian version, in which case it says "Pending Payout in Y days". Which is still perfectly reasonable because the number is still available. So this is more of a consistency fix.

Side Track of My Main Exploration

What was I doing? Well, I was curious what it would take to modify the Steemit UI to show the amounts in a different way, for example, if its value was simply just in STEEM (so that it isn't fluctuating so much based on the market price). At least if it showed it alongside the previous. Problem with that of course is that it's still confusing with SBD being more than 1 USD. Probably would want one that is fully featured, showing both predicted SBD and STEEM POWER payouts with all the information available (even with curation, now that I understand it!). Anyway, that's the dream.

So the first thing I do is to look for where this is being displayed. Well, I know that the STEEM blockchain stores it in the comment object here in the "payout_pending_value" field.

So I search the condenser codebase for it. That let me
here. And then to search for "pending_payout", which revealed several localization files, and that's when I noticed the Russian one was slightly off. I decided to pitch in and correct the typo.

Experience in Contributing

The typo is trivial to correct, and likely I could have just edited it all in the github UI and sent it out. But I wanted to verify everything to make sure it worked. So I followed the steps to build and run my own version of Steemit. Woohoo!

The instructions are easy, and at the front wiki of the github here. At least, I already had a way to get Docker working, also described on that page, which made the steps much simpler.

When following the instructions to build and run locally, of course it didn't work the first time (that's some kind of law, someone give me the name of it...). Nothing loaded, and I got some connection related error that I no longer remember. I suspected it was endpoints that were no longer valid, and was able to find and replace it and modify the configuration file locally to go around it.

Later I would find out that it would be resolved by this pull request. Lesson learned. I should always see if anyone's put it in the issue tracker, because most likely it's not just me.

In any case, being able to successfully pull it up and test out my change was a great experience. That is how I was able to generate the second screenshot of it being fixed.

afterimage

This isn't proof, because someone could have mucked with the developer mode to generate that, so a bit of trust involved there :).

Next Steps

I will keep playing with modifying the codebase for fun, to see if I can get a good breakdown of the payout, though I'm pretty busy already with the normal job, so don't expect too much from me for now :). Cheers. Do let me know if you already know if others doing something similar.



Posted on Utopian.io - Rewarding Open Source Contributors