Always should take profits on the way up. The premise of buy red and sell green is absolutely set aside 75% to hold for long term. 25% should be kept liquid to take profits in an up market. Profits are the rerolled back in in down markets thus growing your portfolio and wealth.