[condenser bug fix] detailed payout info is not shown with 100% beneficiary

blockchainstudio(72)

Published in

#utopian-io

Words

187

Reading

1 min

Listen to this post

~1 min

Project Information

Repository: https://github.com/steemit/condenser
Project Name: Steemit

Issue: https://github.com/steemit/condenser/issues/3450
PR: https://github.com/steemit/condenser/pull/3451

While the PO hasn't acknowledged this (busy for HF21 I guess), this bug is reproducible all the time. I also made a fix and submitted PR.

Expected behavior

Detailed payout info should still be shown when a post with 100% beneficiary is paid out.

Actual behavior

Detailed payout info is not shown when a post with 100% beneficiary is paid out.

How to reproduce

Visit any post with 100% beneficiary, e.g., https://steemit.com/@blockchainstudio/finex-steem-power-liquify

Browser/App version: Any
Operating system: Any

Recording Of The Bug

https://steemit.com/@blockchainstudio/finex-steem-power-liquify

There is no button to show detailed payout info

Cause and Fix

This is due a wrong nonzero payout check condition for paid out post.

total_author_payout is set to zero with 100% beneficiary
Thus, payout should be checked instead.
In addition, !cashout_active is needed to avoid the info is also shown for pending posts.

after fix is applied

Basically this will be more meaningful if beneficiary info is shown (which is also done by me https://github.com/steemit/condenser/pull/3310), but that PR is still pending for a long time :( Steemit may be busy for HF21.